Make core a real dep of server #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d97c6a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
jeresig
approved these changes
Feb 21, 2023
|
Size Change: 0 B Total Size: 4.32 kB ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 59 59
Lines 839 837 -2
Branches 233 224 -9
=========================================
- Hits 839 837 -2
Continue to review full report at Codecov.
|
kevinbarabash
added a commit
that referenced
this pull request
Feb 21, 2023
## Summary: I updated wonder-stuff-server's deps in #544, but missing that wonder-stuff-testing and wonder-stuff-server-google are affected by the same issue. This PR fixes them as well. Issue: None ## Test plan: - Land and wait for #536, see that wonder-stuff-server-google and wonder-stuff-testing are bumped by a minor version Author: kevinbarabash Reviewers: jeresig Required Reviewers: Approved By: jeresig Checks: ✅ codecov/project, ✅ Test (macos-latest, 16.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 16.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ gerald, ✅ Analyze (javascript), ⏭ dependabot Pull Request URL: #545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When reviewing the changes in #536, I noticed that some packages were being bumped a major version even though none of the changeset .md files specified such changes. It appears this is happening due changeset treating peer deps differently from regular deps. This PR fixes the issue by make wonder-stuff-core a regular dependency of wonder-stuff-server.
Issue: None
Test plan: