Skip to content

Commit

Permalink
FEI-4957.4: Run codemod to convert files to TypeScript (#526)
Browse files Browse the repository at this point in the history
## Summary:
This changeset was generated using the follow commands:
- cd ../flow-to-typescript-codemod
- yarn typescriptify convert -p ../wonder-stuff --write --delete
- // manually change 'export {* as jest} from "jest"' to be 'export * as jest from "jest"' in wonder-stuff
- yarn typescriptify fix --autoSuppressErrors --jiraSlug FEI-5011 -p ../wonder-stuff --config ../wonder-stuff/tsconfig.json
- // manually rename prettierrc.ts to prettierrc.js
- cd ../wonder-stuff
- yarn format

The next PR will fix all the TypeScript errors

Issue: FEI-4957

## Test plan:
- yarn tsc --noEmit, see a bunch of errors

```
Found 24 errors in 7 files.

Errors  Files
     2  packages/wonder-stuff-i18n/src/utils/emoji-for-locale.ts:46
    10  packages/wonder-stuff-sentry/src/normalize-sentry-data.ts:34
     2  packages/wonder-stuff-server-google/src/start-server.ts:26
     1  packages/wonder-stuff-server/src/middleware/default-error-logging.ts:18
     1  packages/wonder-stuff-server/src/middleware/default-request-logging.ts:18
     4  packages/wonder-stuff-server/src/start-server.ts:37
     4  packages/wonder-stuff-server/src/types.ts:1
```

Author: kevinbarabash

Reviewers: jeresig, somewhatabstract, kevinbarabash

Required Reviewers:

Approved By: jeresig, somewhatabstract

Checks: ✅ CodeQL, ⏭  Test, ❌ Lint, flow, and coverage check (ubuntu-latest, 16.x), ✅ Analyze (javascript), ✅ gerald, ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ⏭  dependabot

Pull Request URL: #526
  • Loading branch information
kevinbarabash authored Feb 16, 2023
1 parent 929e14b commit 4538fa2
Show file tree
Hide file tree
Showing 146 changed files with 1,095 additions and 1,545 deletions.
11 changes: 11 additions & 0 deletions .changeset/fifty-grapes-guess.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@khanacademy/wonder-stuff-server-google": minor
"@khanacademy/wonder-stuff-testing": minor
"@khanacademy/wonder-stuff-sentry": minor
"@khanacademy/wonder-stuff-server": minor
"@khanacademy/eslint-config": minor
"@khanacademy/wonder-stuff-core": minor
"@khanacademy/wonder-stuff-i18n": minor
---

Migrate to TypeScript
37 changes: 0 additions & 37 deletions flow-typed/@google-cloud/logging-winston.js

This file was deleted.

51 changes: 0 additions & 51 deletions flow-typed/express-winston.js

This file was deleted.

Loading

0 comments on commit 4538fa2

Please sign in to comment.