Skip to content

Commit

Permalink
FEI-4957.8: Remove Flow related plugins, settings, and lib defs (#530)
Browse files Browse the repository at this point in the history
## Summary:
This removes all Flow relate things.

NOTE: `eslint` is currently not running on .ts files.  I'll fix that in the next PR.

Issue: FEI-4957

## Test plan:
Let CI run the checks

Author: kevinbarabash

Reviewers: jeresig, kevinbarabash

Required Reviewers:

Approved By: jeresig

Checks: ⌛ Test (macos-latest, 16.x), ✅ codecov/project, ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 16.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ gerald, ✅ Analyze (javascript), ⏭  dependabot

Pull Request URL: #530
  • Loading branch information
kevinbarabash authored Feb 16, 2023
1 parent 035e345 commit 3d0c41c
Show file tree
Hide file tree
Showing 52 changed files with 16 additions and 3,961 deletions.
5 changes: 5 additions & 0 deletions .changeset/eighty-dancers-flash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/eslint-config": minor
---

Remove Flow eslint rules
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
node_modules
flow-typed/**/*.js
coverage
**/dist
**/*.template
Expand Down
2 changes: 0 additions & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ module.exports = {
"@babel/no-invalid-this": "error",
"@babel/object-curly-spacing": "error",
"@babel/semi": "error",
"ft-flow/no-types-missing-file-annotation": "error",
"ft-flow/no-existential-type": "error",
"import/no-default-export": "error",
"import/no-unresolved": "error",
"import/named": "error",
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
node_modules
coverage
flow-coverage
dist
!.vscode
.DS_Store
Expand Down
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@
*.md
docs
*.yml
flow-typed/npm
2 changes: 0 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"editor.renderWhitespace": "boundary",
"eslint.codeActionsOnSave.mode": "all",
"files.trimTrailingWhitespace": true,
"flow.useNPMPackagedFlow": true,
"typescript.format.enable": false,
"typescript.validate.enable": true,
"javascript.validate.enable": true,
Expand All @@ -11,6 +10,5 @@
},
"todo-tree.filtering.excludeGlobs": [
"**/dist/**",
"**/flow-typed/**"
]
}
5 changes: 0 additions & 5 deletions build-settings/babel.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/* eslint-disable import/no-commonjs */
const createBabelPresets = require("./create-babel-presets");
const createBabelPlugins = require("./create-babel-plugins");

// This config is used for Jest testing here in this repository, only.
module.exports = {
Expand All @@ -11,8 +10,4 @@ module.exports = {
platform: "node",
format: "cjs",
}),
plugins: createBabelPlugins({
platform: "node",
format: "cjs",
}),
};
4 changes: 0 additions & 4 deletions build-settings/create-babel-plugins.js

This file was deleted.

2 changes: 0 additions & 2 deletions build-settings/index.js.flow.template

This file was deleted.

2 changes: 0 additions & 2 deletions build-settings/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {preserveShebangs} from "rollup-plugin-preserve-shebangs";
import rollupExecutable from "rollup-plugin-executable-output";

const createBabelPresets = require("./create-babel-presets");
const createBabelPlugins = require("./create-babel-plugins");

/**
* We support the following config args with this rollup configuration:
Expand Down Expand Up @@ -118,7 +117,6 @@ const createConfig = (
babel({
babelHelpers: "bundled",
presets: createBabelPresets({platform, format}),
plugins: createBabelPlugins({platform, format}),
exclude: "node_modules/**",
extensions,
}),
Expand Down
19 changes: 0 additions & 19 deletions flow-typed/@google-cloud/debug-agent.js

This file was deleted.

14 changes: 0 additions & 14 deletions flow-typed/@google-cloud/profiler.js

This file was deleted.

58 changes: 0 additions & 58 deletions flow-typed/@google-cloud/trace-agent.js

This file was deleted.

35 changes: 0 additions & 35 deletions flow-typed/npm/ancesdir_vx.x.x.js

This file was deleted.

Loading

0 comments on commit 3d0c41c

Please sign in to comment.