Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEI-4957.8: Remove Flow related plugins, settings, and lib defs #530

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

kevinbarabash
Copy link
Contributor

@kevinbarabash kevinbarabash commented Feb 15, 2023

Summary:

This removes all Flow relate things.

NOTE: eslint is currently not running on .ts files. I'll fix that in the next PR.

Issue: FEI-4957

Test plan:

Let CI run the checks

@kevinbarabash kevinbarabash self-assigned this Feb 15, 2023
@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023

🦋 Changeset detected

Latest commit: a5f9e14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@khanacademy/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team February 15, 2023 20:28
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Feb 15, 2023

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .eslintignore, .eslintrc.js, .gitignore, .prettierignore, package.json, tsconfig-check.json, .changeset/eighty-dancers-flash.md, build-settings/babel.config.js, build-settings/rollup.config.js, packages/eslint-config-khan/index.js, packages/eslint-config-khan/package.json, packages/wonder-stuff-core/tsconfig.json, packages/wonder-stuff-i18n/tsconfig.json, packages/wonder-stuff-sentry/tsconfig.json, packages/wonder-stuff-server/tsconfig.json, packages/wonder-stuff-server-google/tsconfig.json, packages/wonder-stuff-testing/tsconfig.json, packages/wonder-stuff-core/src/index.ts, packages/wonder-stuff-sentry/src/kind-sentry-error.ts, packages/wonder-stuff-server/src/get-logging-transport.ts, packages/wonder-stuff-server/src/start-server.ts, packages/wonder-stuff-server-google/src/trace-impl.ts, packages/wonder-stuff-server-google/src/trace.ts, packages/wonder-stuff-testing/src/data-factory-for.ts, packages/wonder-stuff-core/src/__tests__/error-info.test.ts, packages/wonder-stuff-core/src/__tests__/kind-error.test.ts, packages/wonder-stuff-sentry/src/__tests__/kind-error-data.test.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning all of this up!

@@ -72,30 +69,6 @@ module.exports = {
"template-curly-spacing": OFF, // TODO(kevinb): enable this
"valid-jsdoc": OFF, // TODO(kevinb): Enable this since we are using jdocs in some places.

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there TS eslint rules we want to be enabling?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the migration guide has a mapping from Flow rules to TypeScript rules. I'll add those to the config in the next PR when I enable eslint to check .ts files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, ok!

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #530 (a5f9e14) into main (035e345) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #530   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           59        56    -3     
  Lines          845       835   -10     
  Branches       233       224    -9     
=========================================
- Hits           845       835   -10     
Impacted Files Coverage Δ
...kages/wonder-stuff-sentry/src/kind-sentry-error.ts 100.00% <ø> (ø)
...kages/wonder-stuff-server-google/src/trace-impl.ts 100.00% <ø> (ø)
packages/wonder-stuff-server-google/src/trace.ts 100.00% <ø> (ø)
...s/wonder-stuff-server/src/get-logging-transport.ts 100.00% <ø> (ø)
packages/wonder-stuff-server/src/start-server.ts 100.00% <ø> (ø)
...kages/wonder-stuff-testing/src/data-factory-for.ts 100.00% <100.00%> (ø)
packages/wonder-stuff-core/src/kind-error.ts 100.00% <0.00%> (ø)
...ges/wonder-stuff-server-google/src/start-server.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035e345...a5f9e14. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2023

Size Change: -39 B (-1%)

Total Size: 4.32 kB

Filename Size Change
packages/wonder-stuff-core/dist/es/index.browser.js 1.68 kB -39 B (-2%)
ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-sentry/dist/es/index.browser.js 1.66 kB
packages/wonder-stuff-testing/dist/es/index.browser.js 976 B

compressed-size-action

@kevinbarabash kevinbarabash merged commit 3d0c41c into main Feb 16, 2023
@kevinbarabash kevinbarabash deleted the fei-4957.8 branch February 16, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants