-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEI-4957.8: Remove Flow related plugins, settings, and lib defs #530
Conversation
🦋 Changeset detectedLatest commit: a5f9e14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning all of this up!
@@ -72,30 +69,6 @@ module.exports = { | |||
"template-curly-spacing": OFF, // TODO(kevinb): enable this | |||
"valid-jsdoc": OFF, // TODO(kevinb): Enable this since we are using jdocs in some places. | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there TS eslint rules we want to be enabling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the migration guide has a mapping from Flow rules to TypeScript rules. I'll add those to the config in the next PR when I enable eslint to check .ts files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, ok!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 59 56 -3
Lines 845 835 -10
Branches 233 224 -9
=========================================
- Hits 845 835 -10
Continue to review full report at Codecov.
|
Size Change: -39 B (-1%) Total Size: 4.32 kB
ℹ️ View Unchanged
|
58fbf40
to
c0c606e
Compare
dd3b5ea
to
81a3438
Compare
c0c606e
to
695f26e
Compare
81a3438
to
aad269f
Compare
695f26e
to
81ba228
Compare
aad269f
to
be4b4a9
Compare
81ba228
to
37c5f87
Compare
be4b4a9
to
2213133
Compare
37c5f87
to
29374c8
Compare
2213133
to
c199260
Compare
29374c8
to
42c88ea
Compare
c199260
to
0dad912
Compare
0dad912
to
a5f9e14
Compare
Summary:
This removes all Flow relate things.
NOTE:
eslint
is currently not running on .ts files. I'll fix that in the next PR.Issue: FEI-4957
Test plan:
Let CI run the checks