Pull from upstream #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server with a username/password (#3002) * Support LDAP servers where one doesn't first have to bind to the LDAP server with a username/password * Address code climate things
* Don't force an order by created date - any usecases that want this already request it explicitly and it breaks the search function that wants to order by best match. * Fix the logic so that we fall back to a default search order when there's no search term, rather than when there is one and we should use the best-match ordering. * Remove accidentially added blank line
* Update CardsList to use old markup * CR
* extract time limit decisions to a dynamic settings function * introduce environment variable for scheduled query time limits * pass in org_id to query_time_limit * add an interaction test that verifies that time limits are applied to jobs * really important newlines according to CodeClimate
* Add rate limits for user resources. * Disable rate limiting in tests (except for tests that need it). * Update strings to unicode to avoid SQLA warnings
## What type of PR is this? (check all applicable) - [x] Bug Fix ## Description Without this change the Help Drawer couldn't load content anymore. ## Related Tickets & Documents #3404
## What type of PR is this? (check all applicable) <!-- Please leave only what's applicable --> - [x] Refactor - [x] Bug Fix ## Description This basically makes sure that when import the redash package we don't accidentally trigger import-time side-effects such as requiring Redis. Refs #3569 and #3466.
* feature: add couchbase query runner * fix style * fix style * fix style * fix naming due to convention * extracting protocol as parameter
* support multiple associations of the same query-based dropdown parameter * include several query-based parameters in association tests
This would for example allow adding custom job labels (https://cloud.google.com/bigquery/docs/adding-using-labels#job-label) for easier accounting.
Nodejs has set max header size to 8k in http_parser, need to provide a larger header size to make the proxy work.
* Fix query based parameter value null when created * Use toString to avoid having 'null' string
This reverts commit ab5494a.
* Allow multiple values for enum parameter * Allow multi-select for Query dropdown parameters * CR + make sure list values are allowed * Add prefix, suffix and separator * Rename multipleValues and cast options as strings * Replicate serialization logic on frontend * Add Quote Option Select * Make sure it's enum or query before join * Add a couple of tests * Add help to quote option * Add min-width and normalize empty array * Improve behavior when changing parameter settings - Set parameter value again to pass through checks - Add setValue check for multi values * Validate enum values on setValue + CodeClimate * Ran wording suggestions * Updates after Apply Changes * Fix failing Cypress tests * Make sure enumOptions exists before split * Improve propTypes for QueyBasedParameterInput Co-Authored-By: Ran Byron <[email protected]> * CR * Cypress: Test for multi-select Enum * Fix multi-selection Cypress spec * Update Refresh Schedule
* move event recording for query executions inside run_query * include indication of cache hit or miss inside execute_query events
* avoid using 'abort' in parameterized query - raise an exception instead * when facing invalid parameters or detached dropdown queries - continue to refresh the rest of the outdated queries * test that dropdown queries detached from data source raise an exception when fetch values is attempted * test that queries with invalid parameters arent refreshed * test that queries with dropdown query parameters which are detached from the data source are skipped * fix stale test double name * newlines. newlines everywhere. * pass org into dropdown_values * pass in org in every ParameterizedQuery usage * Update redash/tasks/queries.py Co-Authored-By: Arik Fraimovich <[email protected]> * reduce refresh_queries log noise * track failure count for queries that failed to apply parameters, and also notify the failures * Update redash/tasks/queries.py Co-Authored-By: Arik Fraimovich <[email protected]> * newlines. newlines everywhere.
* Fix W292 no newline at end of file * Fix extra whitespace * Fix E305 expected 2 blank lines after class or function definition * Fix W391 blank line at end of file * Fix E231 missing whitespace after * Fix E303 too many blank lines * Fix E302 expected 2 blank lines * Fix E128 continuation line under-indented for visual indent
* Dont send password reset link to disabled users * Update email subject * Update blocked email text. * Update blocked email text (plain text version). * Remove debug print.
* Fix: remove inline script to avoid CSP violation Closes #4039. * Restore eslint rule that prevents javascript href attributes. * Remove all inline script links.
With the default Docker installed from sources on Ubuntu 19.04 it failed starting the project when asking for Compose version 3.7, but everything worked fine with 3.2.
…4028) * allowing to specify a custom work group for AWS Athena queries * Fixing title + adding correct position in the UI * Adding assume role configuration to Athena query runner. * removing extra blank lines * fixes based on comments to the PR
* Fix loading of periodic tasks and clean up extension loading. This does a few things: - add tests for extension loading - refactor the extension and periodic task loading - better handle assertions raised by extensions (e.g. when an extension tries to override an already registered view) - attach exception traceback to error log during loading for improved debugging * Use site.addsitedir instead of calling pip. * Use sys.path instead of site.addsitedir and also the setup.py egg_info command.
* Initial commit for adding Dgraph support * Made suggestions from https://codeclimate.com/github/getredash/redash/pull/3964 * feedback from @arikfr * added logo for Dgraph from Twitter * Better conversion of Dgraph JSON to Redash's internal JSON * made recommendations from @arikfr * removed unused function
Jakdaw
pushed a commit
that referenced
this pull request
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)