Split redash/__init__.py to prevent import time side-effects. #3601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
3 tasks
jezdez
commented
Mar 18, 2019
| from .organization import DATE_FORMAT | ||
|
|
||
|
|
||
| def all_settings(): |
There was a problem hiding this comment.
This isn't needed since Flask has app.config.from_object
jezdez
commented
Mar 18, 2019
| from .utils import routes | ||
|
|
||
|
|
||
| class Redash(Flask): |
There was a problem hiding this comment.
I basically tried to separate Flask app specific code in the flask.Flask subclass and all Redash specific code in the create_app function.
jezdez
commented
Mar 18, 2019
jezdez
commented
Mar 18, 2019
jezdez
commented
Mar 18, 2019
jezdez
commented
Mar 18, 2019
arikfr
reviewed
Mar 18, 2019
|
@arikfr Is there anything else needed to merge this? |
arikfr
reviewed
Apr 14, 2019
jezdez
force-pushed
the
import-side-effects
branch
from
09b18da
to
a279e7a
Compare
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
…ash#3601) ## What type of PR is this? (check all applicable) <!-- Please leave only what's applicable --> - [x] Refactor - [x] Bug Fix ## Description This basically makes sure that when import the redash package we don't accidentally trigger import-time side-effects such as requiring Redis. Refs getredash#3569 and getredash#3466.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This basically makes sure that when import the redash package we don't accidentally trigger import-time side-effects such as requiring Redis.
Refs #3569 and #3466.