Fix search ordered by best match #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring up to date
Update from getredash/redash
this already request it explicitly and it breaks the search function that wants to order by best match.
…re's no search term, rather than when there is one and we should use the best-match ordering.
|
I'm not really following this code anymore (and I wrote it), so maybe it would make sense to refactor the |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* Don't force an order by created date - any usecases that want this already request it explicitly and it breaks the search function that wants to order by best match. * Fix the logic so that we fall back to a default search order when there's no search term, rather than when there is one and we should use the best-match ordering. * Remove accidentially added blank line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Make searches order by best-match (unless something else is explicitly requested).
Related Tickets & Documents
See discussion at:
https://discuss.redash.io/t/searching-for-queries-after-upgrade-to-v5/2590/6
Mobile & Desktop Screenshots/Recordings (if there are UI changes)