Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assume role as a credential source for AWS Athena Query runner #4028

Merged
merged 6 commits into from
Aug 12, 2019

Conversation

ialeinikov
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

If enabled (via environment variable flag) exposes alternative assume role to be used instead of an IAM user.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Screen Shot 2019-08-01 at 11 39 33 AM

Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but see comments. Thanks!

redash/query_runner/athena.py Outdated Show resolved Hide resolved
redash/query_runner/athena.py Outdated Show resolved Hide resolved
@arikfr arikfr merged commit be142d6 into getredash:master Aug 12, 2019
@arikfr
Copy link
Member

arikfr commented Aug 12, 2019

Thanks!

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
…etredash#4028)

* allowing to specify a custom work group for AWS Athena queries

* Fixing title + adding correct position in the UI

* Adding assume role configuration to Athena query runner.

* removing extra blank lines

* fixes based on comments to the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants