Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix according to pycodestyle format #4011

Merged
merged 8 commits into from
Aug 11, 2019

Conversation

yoshiken
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Corrected the code style to pep8.
A correction that does not affect the operation.

before

$pycodestyle redash/|wc -l                                                                                                                                                     181

after

$pycodestyle redash/|wc -l                                                                                                                                                     111

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@arikfr arikfr merged commit a7b14bf into getredash:master Aug 11, 2019
@arikfr
Copy link
Member

arikfr commented Aug 11, 2019

Thanks, but in the future please avoid opening style only changing pull requests. Until we adopt a single formatting tool (#3806) we prefer to address these things on an adhoc basis, when editing the code in a specific file.

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
* Fix W292 no newline at end of file

* Fix extra whitespace

* Fix E305 expected 2 blank lines after class or function definition

* Fix W391 blank line at end of file

* Fix E231 missing whitespace after

* Fix E303 too many blank lines

* Fix E302 expected 2 blank lines

* Fix E128 continuation line under-indented for visual indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants