Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Black for formatting Python code #3806

Closed
arikfr opened this issue May 15, 2019 · 1 comment · Fixed by #4297
Closed

Adopt Black for formatting Python code #3806

arikfr opened this issue May 15, 2019 · 1 comment · Fixed by #4297
Labels
Backend Python 3

Comments

@arikfr
Copy link
Member

arikfr commented May 15, 2019 •
edited
Loading

Black is being adopted by Django and other projects as the default formatter, and it makes sense for us to adopt it too. Only blocker is the fact it needs Python 3 to run, but our codebase is still Python 2.

While Black can format Python 2, without us making the switch it will be harder for developers to run the tool.

Blocked by: #4181.
@jezdez
Copy link
Member

jezdez commented May 15, 2019

🏴

@weekly-digest weekly-digest bot mentioned this issue May 20, 2019
Closed
@arikfr arikfr mentioned this issue Aug 11, 2019
Merged
6 tasks
@arikfr arikfr mentioned this issue Oct 27, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backend Python 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Black support for the Python codebase getredash/redash
2 participants
@jezdez @arikfr