Added arrow to multi-select component #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also needs to add the arrow to the Query Based Dropdown Parameter. |
|
@gabrieldutra I would really like to also make it not |
Go ahead, It is a waste of space indeed, my only concern is when it's empty-valued, but we can experience that with the arrow. One option is to add a placeholder in case it turns out to be weird looking. |
|
Now that there's an arrow, it's obvious that the remaining space is clickable.
|
It'll look exactly like an empty single value dropdown having minimum |
gabrieldutra
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added arrow to Select.
Fixes #4042.