Fix Ability to save with Multiple Dropdown Parameters #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchy
changed the base branch from
master
to
fix-add-query-based-parameter-to-existing-queries
kravets-levko
approved these changes
Apr 17, 2019
gabrieldutra
approved these changes
Apr 17, 2019
rauchy
changed the base branch from
fix-add-query-based-parameter-to-existing-queries
to
master
rauchy
changed the base branch from
master
to
fix-add-query-based-parameter-to-existing-queries
rauchy
force-pushed
the
fix-save-with-multiple-dropdown-parameters
branch
from
9041bdb
to
422c192
Compare
rauchy
changed the base branch from
fix-add-query-based-parameter-to-existing-queries
to
master
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* support multiple associations of the same query-based dropdown parameter * include several query-based parameters in association tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Turns out the association safety check should have included distinct values.
Related Tickets & Documents
Fixes #3710
Mobile & Desktop Screenshots/Recordings (if there are UI changes)