Fix Ability to save with Multiple Dropdown Parameters (getredash#3717)

* support multiple associations of the same query-based dropdown parameter * include several query-based parameters in association tests
pushpay · Nov 14, 2019 · d7fa026 · d7fa026
1 parent b8b4103
commit d7fa026
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/redash/handlers/queries.py b/redash/handlers/queries.py
@@ -174,13 +174,13 @@ def get(self):
 
 def require_access_to_dropdown_queries(user, query_def):
     parameters = query_def.get('options', {}).get('parameters', [])
-    dropdown_query_ids = [str(p['queryId']) for p in parameters if p['type'] == 'query']
+    dropdown_query_ids = set([str(p['queryId']) for p in parameters if p['type'] == 'query'])
 
     if dropdown_query_ids:
         groups = models.Query.all_groups_for_query_ids(dropdown_query_ids)
 
         if len(groups) < len(dropdown_query_ids):
-            abort(400, message="You are trying to associate a dropdown query that does not have a matching group."
+            abort(400, message="You are trying to associate a dropdown query that does not have a matching group. "
                                "Please verify the dropdown query id you are trying to associate with this query.")
 
         require_access(dict(groups), user, view_only)

diff --git a/tests/handlers/test_queries.py b/tests/handlers/test_queries.py
@@ -122,6 +122,11 @@ def test_allows_association_with_authorized_dropdown_queries(self):
 
         options = {
             'parameters': [{
+                'name': 'foo',
+                'type': 'query',
+                'queryId': other_query.id
+            }, {
+                'name': 'bar',
                 'type': 'query',
                 'queryId': other_query.id
             }]
@@ -251,6 +256,11 @@ def test_allows_association_with_authorized_dropdown_queries(self):
             'data_source_id': self.factory.data_source.id,
             'options': {
                 'parameters': [{
+                    'name': 'foo',
+                    'type': 'query',
+                    'queryId': other_query.id
+                }, {
+                    'name': 'bar',
                     'type': 'query',
                     'queryId': other_query.id
                 }]