Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @automattic/wordpress-external-dependencies-plugin #6

Closed
DanReyLop opened this issue Mar 6, 2019 · 5 comments
Closed

Use @automattic/wordpress-external-dependencies-plugin #6

DanReyLop opened this issue Mar 6, 2019 · 5 comments
Assignees

Comments

@DanReyLop
Copy link
Contributor

After adding the merchant dashboard page in #5, add a minimal React-based application in there. It doesn't need to have anything to do with the final product, but this task will encompass:

  • Adding a Webpack config.
  • Adding a package.json with at least some @wordpress/* and @woocommerce/* dependencies.
  • Adding a way for the PHP side of the plugin to render the React-based app.
  • Adding production and development modes like in WCS.
@dechov
Copy link
Contributor

dechov commented Mar 18, 2019

I think Automattic/wp-calypso#31513 could be relevant? Should keep an eye on it.

@sirreal
Copy link
Member

sirreal commented Mar 19, 2019

👋 I'd be happy to chat about Automattic/wp-calypso#31513

I'd love to see it tested in some different situations.

@dechov
Copy link
Contributor

dechov commented Mar 26, 2019

Gutenberg 5.3 includes webpack and babel configs that we may want to use (or else align with) [announcement, handbook, incl. extending webpack config].

@sirreal
Copy link
Member

sirreal commented Apr 8, 2019

The Webpack plugin is live and in use in Jetpack. It currently handles the basic @worpress/*, react, and a few other dependencies.

We'll be looking at extending the API in a way that you could use to extern @woocommerce/* deps as well: Automattic/wp-calypso#32097

Core is looking at adopting the plugin as well: WordPress/gutenberg#14837

@v18 v18 changed the title Add a minimal React-based merchant dashboard using wc-admin components Use @automattic/wordpress-external-dependencies-plugin Apr 12, 2019
@v18 v18 self-assigned this Apr 17, 2019
@DanReyLop
Copy link
Contributor Author

DanReyLop commented May 12, 2019

I don't know what happened to this issue's title, but this issue was meant to be Add a minimal React-based merchant dashboard using wc-admin components, which has already been covered by #43.

Edit: Also, per #52, we are going to use the @wordpress webpack plugin instead of the @automattic one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants