This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
2.15.0 #996
Closed
2.15.0 #996
+100,436
−44,973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![nextreleaseio[bot]](https://avatars.githubusercontent.com/in/26967?s=60&v=4){kind=small}
…th_settings Sync hier attributes with settings
…sage Remove get_application usage
Pype: add vendor folder
Removed project from Widget, left project on model only
…date Fix update of project's tasks on Ftrack sync
…ture_action Create project structure action fix multiroot
Ftrack plugins in ftrack module
Pype 3: Use Poetry
Get creator by name fix
…ute_update Fix Ftrack custom attribute update
…t-thumb fix(nuke): missing preset's variable
Maya: Alembic only set attributes that exists
…set-in-mov-loader nuke: wrong frame offset in mov loader
nextreleaseio
bot
requested review from
antirotor,
iLLiCiTiT,
jakubjezek001,
kalisp and
mkolar
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
./pype/hosts/nuke/api/utils.py:51:38: B008: Do not perform function calls in ...
./pype/hosts/nuke/api/utils.py:51:38: B008: Do not perform function calls in argument defaults. The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call. If this is intended, assign the function call to a module-level variable and use that variable as a default value.
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 11, in
sys.exit(main())
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
app.run(argv)
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
self._run(argv)
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run
self.run_checks()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks
self.file_checker_manager.run()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run
self.run_serial()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial
checker.run_checks()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks
self.run_ast_checks()
File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks
for (line_number, offset, text, check) in runner:
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run
parser.visit(self.tree)
File "/usr/lib/python3.6/ast.py", line 253, in visit
return visitor(node)
File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
self.visit(item)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef
self.capture_issues_visitor('ClassDef', node)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
self.generic_visit(node)
File "/usr/lib/python3.6/ast.py", line 263, in generic_visit
self.visit(value)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call
self.capture_issues_visitor('Call', node)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
issues = checker.run(node)
File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run
if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'
| if output is None: | ||
| output = default_output | ||
| return output | ||
| return default_output |
| if matching_item is not None: | ||
| output = matching_item.get("enabled") | ||
| if output is None: | ||
| output = default_output |
| project_settings['Workfiles']['last_workfile_on_startup']) | ||
|
|
||
| if not startup_presets: | ||
| return default_output |
| Anatomy, | ||
| get_project_settings | ||
| ) | ||
| from pype.lib import ( |
There was a problem hiding this comment.
'pype.lib.env_value_to_bool' imported but unused
| # frames from Deadline Monitor | ||
| "OutputFilename0": output_filename_0.replace("\\", "/"), | ||
|
|
||
| # # Asset dependency to wait for at least the scene file to sync. |
| @@ -0,0 +1,212 @@ | |||
| import os | |||
| GN = nuke.toNode(container['objectName']) | ||
|
|
||
| file = api.get_representation_path(representation).replace("\\", "/") | ||
| context = representation["context"] |
There was a problem hiding this comment.
local variable 'context' is assigned to but never used
| bdn["bdheight"].setValue(bdheight) | ||
|
|
||
| bdn["name"].setValue(object_name) | ||
| bdn["label"].setValue("Version tracked frame: \n`{}`\n\nPLEASE DO NOT REMOVE OR MOVE \nANYTHING FROM THIS FRAME!".format(object_name)) |
| xpos = bdn.xpos() - bdn_frame | ||
| ypos = bdn.ypos() - bdn_frame | ||
| bdwidth = bdn["bdwidth"].value() + (bdn_frame*2) | ||
| bdheight = bdn["bdheight"].value() + (bdn_frame*2) |
There was a problem hiding this comment.
missing whitespace around arithmetic operator
| # add frame offset | ||
| xpos = bdn.xpos() - bdn_frame | ||
| ypos = bdn.ypos() - bdn_frame | ||
| bdwidth = bdn["bdwidth"].value() + (bdn_frame*2) |
There was a problem hiding this comment.
missing whitespace around arithmetic operator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(2021-02-08)
Full Changelog
Enhancements:
Fixed bugs:
fileknob update #933Implemented Enhancements
Fixed Bugs
fileknob update nuke: missingfileknob update #935 @jezschaOther Changes