Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Launcher fix actions discover #896

Merged
merged 17 commits into from
Jan 20, 2021
Merged

Launcher fix actions discover #896

merged 17 commits into from
Jan 20, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jan 19, 2021 •
edited
Loading

Issue

  • discovery of actions in launcher is broken that clicking on first project in project list won't discover actions

Changes

  • launcher items do not hold session data separately but are corresponding to dbcon.Session which is used across all widgets
  • widgets/models/views access less to children of their children
  • actions are now discovered on launcher show event and on project change properly
    • TODO add refresh/reset method to main launcher window to also refresh projects which is not possible right now
  • actions have set tooltips to their labels so it is possible to see whole label on hover

@iLLiCiTiT
ActionBar has new methods for discover and filter of actions
984b769
@iLLiCiTiT
discover actions discover all actions and only when project is specif…
eb58f12 
…ied then tries project specific actions
@iLLiCiTiT
ActionModel does not use inner session attribute but cares about dbco…
eebc76a 
…n session
@iLLiCiTiT
discover is not triggered on initialization of action model
73bdc8b
@iLLiCiTiT
renamed method refresh to filter_actions
70e5d02
@iLLiCiTiT
do not register refreshed callback all the time
6ad0649
@iLLiCiTiT
reorganized imports to multiline
492e6e4
@iLLiCiTiT
added session_changed signal to ProjectsPanel
7c54474
@iLLiCiTiT
Launcher does not register signals from its children children widgets
cf468f4
@iLLiCiTiT
separated discover_actions and filter_actions in launcher widget
bb60f2d
@iLLiCiTiT
on back clicked sets project to None
16e5f34
@iLLiCiTiT
get_current_session is not used
ec1c0bf
@iLLiCiTiT
launcher will discover actions on show
6d34d20
@iLLiCiTiT
on asset_change changes session data
c26d70b
@iLLiCiTiT
added on task change callbacks
c1326af
@iLLiCiTiT
set_project also triggers on_project_changed
418135b
@iLLiCiTiT iLLiCiTiT self-assigned this Jan 19, 2021
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Jan 19, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team January 19, 2021 15:15
@mkolar mkolar added this to the 2.15.0 milestone Jan 20, 2021
@mkolar mkolar added the 2x-dev label Jan 20, 2021
@mkolar mkolar merged commit 929dddd into 2.x/develop Jan 20, 2021
@mkolar mkolar deleted the feature/launcher_fix_actions_discover branch January 26, 2021 08:49
@nextreleaseio nextreleaseio bot mentioned this pull request Feb 8, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar