This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Pype 3: Use Poetry #958
Merged
Pype 3: Use Poetry #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This already has #943 merged in and switched to Poetry |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| # Set new PYTHONPATH to launch context environments | ||
| self.launch_context.env["PYTHONPATH"] = os.pathsep.join(python_paths) | ||
|
|
There was a problem hiding this comment.
blank line at end of file
blank line contains whitespace
|
Looking very good. To make this complete we need to add better handling of python 2 environments. But that can be done in a separate PR |
mkolar
approved these changes
Feb 4, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Switch dependency a virtual environment management to Poetry. This has many advantages:
Close #943