Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Get creator by name fix #980

Merged
merged 3 commits into from
Feb 5, 2021
Merged

Get creator by name fix #980

merged 3 commits into from
Feb 5, 2021

Conversation

iLLiCiTiT
Copy link
Member

Issue

  • Maya's Referrence loader and Blender's Layout loader are creating instances during loading and are expecting that avalon.api.create can work with only family which is not possible since PR in avalon-core

Suggested solution

  • implemented function get_creator_by_name that returns creator plugin but it's name
  • loaders have defined creator name that will be used to create new instances and use get_creator_by_name to use it

Note

The function get_creator_by_name returns None if none of registered creator plugins match to entered name and loaders will raise an error if that happens. Should the error be raised? Should be raise inside the loader or inside get_creator_by_name?

🏴 Pype 2.x PR
pype #979

@iLLiCiTiT iLLiCiTiT mentioned this pull request Feb 4, 2021
@iLLiCiTiT iLLiCiTiT self-assigned this Feb 4, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team February 4, 2021 17:58
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Feb 4, 2021
@mkolar mkolar merged commit d5e6fe2 into develop Feb 5, 2021
@nextreleaseio nextreleaseio bot mentioned this pull request Feb 8, 2021
@mkolar mkolar deleted the feature/3.0_get_creator_by_name branch February 10, 2021 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants