Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Unreal: animation, layout and setdress updates #695

Merged
merged 24 commits into from
Dec 16, 2020

Conversation

simonebarbieri
Copy link
Contributor

No description provided.

This layout is made to work with Blender. The layout exports a json file with the reference to the blend files in ftrack that generated the fbx that has been imported in Unreal. In Blender, when the layout is loaded, pype will load the assets from the blend files and set the transform from the layout.
When reopening the Unreal project, the skeleton was not connected to the skeletal mesh anymore. Some materials were not assigned to the mesh either.
rep = None
pub_repr = i.data.get('published_representations')
for elem in pub_repr:
if pub_repr.get(elem).get('representation').get('name') == "fbx":
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (81 > 79 characters)

@@ -0,0 +1,49 @@
import json

from avalon import io
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'avalon.io' imported but unused


self.log.info("Extracted instance '{}' to: {}".format(
instance.name, json_representation))

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line at end of file

json_dict = {}
json_dict['subset'] = i.data.get('subset')
json_dict['container'] = container.name
json_dict['instance_name'] = container.get('avalon').get('instance_name')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (89 > 79 characters)


import bpy

class ExtractSetDress(pype.api.Extractor):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1


for c in bpy.data.collections:
metadata = c.get('avalon')
if metadata:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

import logging
from pathlib import Path
from pprint import pformat
from typing import Dict, List, Optional

from avalon import api, blender
from avalon import api, blender, pipeline
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'avalon.pipeline' imported but unused

@@ -1,11 +1,15 @@
"""Load a layout in Blender."""

import json
from logging import log, warning
import math
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'math' imported but unused

@@ -1,11 +1,15 @@
"""Load a layout in Blender."""

import json
from logging import log, warning
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'logging.log' imported but unused
'logging.warning' imported but unused

from avalon import api, blender
import pype.hosts.blender.plugin

class CreateSetDress(blender.Creator):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

@mkolar mkolar added type: enhancement Enhancements to existing functionality host: UE labels Nov 17, 2020
@antirotor
Copy link
Member

Update to launch Unreal 4.26 from ftrack action: #746

@mkolar mkolar force-pushed the 2.x/develop branch 2 times, most recently from 46534d7 to 461dc0e Compare December 8, 2020 16:58
@mkolar mkolar added this to the 2.15.0 milestone Dec 16, 2020
@mkolar mkolar changed the title Feature/Unreal Support Unreal: animation, layout and setdress updates Dec 16, 2020
@mkolar
Copy link
Member

mkolar commented Dec 16, 2020

happy to merge in this state.

@mkolar mkolar merged commit 3f20b26 into ynput:2.x/develop Dec 16, 2020
This was referenced Dec 16, 2020
@nextreleaseio nextreleaseio bot mentioned this pull request Feb 8, 2021
@simonebarbieri simonebarbieri deleted the feature/unreal-support branch April 14, 2021 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Blender host: UE type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants