Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.72.0 #4668

Merged
merged 13 commits into from
Mar 18, 2022
Merged

Release 1.72.0 #4668

merged 13 commits into from
Mar 18, 2022

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Mar 17, 2022

Release for Gutenberg Mobile 1.72.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Add GIF badge for animated GIFs uploaded to Image blocks

Small refinement to media upload errors, including centering and tweaking copy.

Update gesture handler and reanimated libraries

Fix issue with list's starting index and the order

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@jhnstn jhnstn requested a review from hypest March 18, 2022 01:01
@jhnstn jhnstn marked this pull request as ready for review March 18, 2022 01:01
@hypest
Copy link
Contributor

hypest commented Mar 18, 2022

Should we update to the latest Gutenberg hash on the Gutenberg side release branch? Currently we are pointing to 8a92c89e08d251b0ed36b580fdf4a63646557c38 but need to point to 064805cd263ccfae965d27949bffeb08378b7397? 🤔

@hypest
Copy link
Contributor

hypest commented Mar 18, 2022

🤦‍♂️, I had forgotten to add a release note entry for this lists fix (user-facing) @jhnstn. We can add it directly to the release branches perhaps, what do you think?

@jhnstn
Copy link
Member Author

jhnstn commented Mar 18, 2022

Should we update to the latest Gutenberg hash on the Gutenberg side release branch? Currently we are pointing to 8a92c89e08d251b0ed36b580fdf4a63646557c38 but need to point to 064805cd263ccfae965d27949bffeb08378b7397? 🤔

Correct. the order of running the release script, updates, and review requests needs a bit of refinement. Updating the GB reference is part of the "Integrate the Release (Thursday)" steps. What's tricky is that the update change log step happens after the release script runs. The easiest fix right now is too not updating the GB ref in the GBM release PR after updating the release notes on Gutenberg, then mark the PRs as ready to review

jhnstn added 3 commits March 18, 2022 09:38
And update Gutenberg Ref to point to the companion change
RELEASE-NOTES.txt Outdated Show resolved Hide resolved
Co-authored-by: Stefanos Togoulidis <[email protected]>
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhnstn jhnstn merged commit 95b331d into trunk Mar 18, 2022
@jhnstn jhnstn deleted the release/1.72.0 branch March 18, 2022 19:50
@hypest
Copy link
Contributor

hypest commented Mar 21, 2022

@hypest
Copy link
Contributor

hypest commented Mar 22, 2022

🟢 Unsupported Block Tests (Android)

Tested with build 19.5-rc-1 on a Pixel 2XL (Android 11).

Unsupported Block Tests

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites. ⚠️ Issue with dark mode
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@jhnstn
Copy link
Member Author

jhnstn commented Mar 22, 2022

🟢 iOS - Writing Flow checklist

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@jhnstn
Copy link
Member Author

jhnstn commented Mar 22, 2022

🟢 iOS Unsupported Block Tests


  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@jhnstn
Copy link
Member Author

jhnstn commented Mar 22, 2022

🟢 iOS Sanity Test Suite 1

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • Columns - Columns percentage mechanism - column's slider input - TC020
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011
  • Columns - Deep nesting is possible (iOS only)- TC012

Columns - 3

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009
  • Cover - Image focal point is rendered properly - TC003
  • Cover - Custom color is rendered properly - TC004
  • ⚠️ found focus issue with Cover block

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

@jhnstn
Copy link
Member Author

jhnstn commented Mar 23, 2022

🟢 iOS Sanity Test Suite 2

DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - AppenderButton is rendered - TC001
  • Group - Deep nesting is possible (iOS only) - TC002
  • Group - Check if Group placeholder is visible for the unselected state - TC003
  • Group - Check if Group placeholder is render in nested structure - TC004
  • Group - Nested block have proper border styling - TC005
  • Group - Nested block have proper margins values - TC006
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008

Spacer - 1

  • Spacer block - Spacer is rendered without crash - TC001
  • Spacer block - Settings: Control spacer height using the slider - TC002
  • Spacer block - Settings: Control spacer height using the text input - TC003

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
  • Buttons block - Buttons inline appender - TC002
  • Buttons block - Add another Button inside Buttons using inserter - TC003
  • Buttons block - Button's wrapper grows properly - TC023

Buttons-2

  • Buttons block - Removing Button along with Buttons block - TC004
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

  • Buttons block - Wrapping Buttons - TC006
  • Buttons block - Buttons alignment options - TC007

Button-6

  • Buttons block - Settings: Open in new tab - TC011
  • Buttons block - Settings: Link rel - TC012
  • Buttons block - Settings: Link URL - TC010
  • Buttons block - Settings: Remove link - TC014
  • Buttons block - Settings: Synchronize with button options - TC013

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

@jhnstn
Copy link
Member Author

jhnstn commented Mar 23, 2022

iOS Sanity Test Suite 3

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC004
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Gallery - 4

  • Gallery block - Settings: Link to - TC012 skipped
  • Gallery block - Settings: Column number - TC013
  • Gallery block - Settings: Crop images - TC014

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - TC018

MediaText - 3

  • Media Text block - Insert video from device (failing) - TC001-v
  • Media Text block - Close/Re-open post with an ongoing video upload - TC003-v

MediaText - 4

  • Media Text block - Media & Text alignment - TC006
  • Media Text block - Vertical alignment - TC007

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover - 2

  • Cover - Add Video Background from WordPress Media library - TC005
  • Cover - Replace media - TC006
  • Cover - Gradient background is rendered properly - TC007
  • Cover - Gradient overlay is rendered properly - TC008

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - TC004
  • Ghost placeholder is visible when no icon is active - TC005
  • Social icon forwarding to the link - TC006

Image - 2

  • Image block - Border style setting - TC006
  • Image block - Image size setting - TC007
  • Image block - Link to setting - TC008

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@hypest
Copy link
Contributor

hypest commented Mar 23, 2022

🟢 Writing Flow Test Cases (Android)

Tested with build 19.5-rc-1 on a Pixel 2XL (Android 11).

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word. ⚠️ Works, but found this issue when different block was focused
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@hypest
Copy link
Contributor

hypest commented Mar 23, 2022

🟢 Test Suite 1 (Android)

Tested with build 19.5-rc-1 on a Pixel 2XL (Android 11).

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • Columns - Columns percentage mechanism - column's slider input - TC020
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011
  • Columns - Deep nesting is possible (iOS only)- TC012 🙌 works fine on Android too.

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - TC002
  • Columns - Appearance in vertical device position (vertical layout) - TC013
  • Columns - Appearance in horizontal device position (horizontal layout) - TC014. ⚠️ Known issue
  • Columns - Mover direction - TC015
  • Columns - Check if Column placeholder is render in nested structure - TC016
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009
  • Cover - Image focal point is rendered properly - TC003
  • Cover - Custom color is rendered properly - TC004

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

@fluiddot fluiddot restored the release/1.72.0 branch March 30, 2022 13:28
@fluiddot fluiddot deleted the release/1.72.0 branch March 30, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants