Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gesture handler and reanimated libraries #4615

Merged
merged 15 commits into from
Mar 3, 2022
Merged

Update gesture handler and reanimated libraries #4615

merged 15 commits into from
Mar 3, 2022

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Feb 28, 2022 •
edited
Loading

Gutenberg PR: WordPress/gutenberg#39098
WordPress-Android PR: wordpress-mobile/WordPress-Android#16033
WordPress-iOS PR: wordpress-mobile/WordPress-iOS#18065

To test:
Follow the testing instructions described in WordPress/gutenberg#39098.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot self-assigned this Feb 28, 2022
@fluiddot fluiddot mentioned this pull request Feb 28, 2022
Closed
@fluiddot fluiddot mentioned this pull request Feb 28, 2022
Merged
8 tasks
@fluiddot fluiddot linked an issue Mar 1, 2022 that may be closed by this pull request
[Drag & Drop blocks] Upgrade dependencies related to gesture handling and animation #4555
Closed
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 1, 2022 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot added this to the 1.72.0 milestone Mar 1, 2022
@fluiddot fluiddot added the dependencies Pull requests that update a dependency file label Mar 1, 2022
@fluiddot fluiddot marked this pull request as ready for review March 1, 2022 12:28
@fluiddot fluiddot requested a review from geriux March 1, 2022 12:28
fluiddot
fluiddot commented Mar 1, 2022
View reviewed changes
third-party-podspecs/react-native-video.podspec.json
"version": "5.0.2-wp-2",
"version": "5.2.0-wp-2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like react-native-video was recently updated (reference) but its podspec wasn't updated.

@fluiddot fluiddot mentioned this pull request Mar 2, 2022
Merged
3 tasks
geriux
geriux approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This aligns with the changes on Gutenberg approved as well. 🚀

@fluiddot fluiddot mentioned this pull request Mar 2, 2022
Merged
4 tasks
@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 2, 2022 •
edited
Loading

LGTM! This aligns with the changes on Gutenberg approved as well. 🚀

Thanks @geriux for reviewing the PRs 🙇! I've just referenced in the PR's description the WordPress-Android and WordPress-iOS PRs, in case you could take a look at them.

I noticed that the Android installable build is not working due to this error, I'm currently investigating it but it's likely that it would require further changes in all PRs. I'll let you know when I apply the fix, thanks!

@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 2, 2022

I noticed that the Android installable build is not working due to this error, I'm currently investigating it but it's likely that it would require further changes in all PRs. I'll let you know when I apply the fix, thanks!

The fix has been already applied, now both WordPress-Android and WordPress-iOS are ready for review 🎊 .

@fluiddot fluiddot enabled auto-merge March 3, 2022 09:48
@fluiddot fluiddot merged commit a09b1d0 into trunk Mar 3, 2022
@fluiddot fluiddot deleted the drag-and-drop/update-gesture-and-animation-deps branch March 3, 2022 10:15
This was referenced Mar 15, 2022
Merged
Merged
@jhnstn jhnstn mentioned this pull request Mar 17, 2022
Merged
4 tasks
@fluiddot fluiddot mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@fluiddot fluiddot

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.72.0 (19.5)
Development

Successfully merging this pull request may close these issues.

[Drag & Drop blocks] Upgrade dependencies related to gesture handling and animation
2 participants
@fluiddot @geriux