Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Blocks: no warning about exceeding the site storage limit and a generic error appears when over disk quota #2448

Closed
designsimply opened this issue Jun 30, 2020 · 7 comments
Assignees
Labels
Media Project: Flow improvements Revise/enhance various editing flows [Type] Bug Something isn't working

Comments

@designsimply
Copy link
Contributor

Steps to reproduce:

  1. For a WordPress.com Free site, go to My Site > Media.
  2. Add items until you run out of space.
  3. Go to My Site > Blog Posts > +.
  4. Add a title and an image block.
  5. Upload an image that exceeds the site storage limit.

Result: I expected to see a warning about going over storage capacity but a generic error saying "Failed to insert media. Please tap for options." When I tap the image it says, "Retry uploading?" and has options to retry all, remove, or retry and doesn't say anything about the storage limit. (1m40s)

image-block-failed-to-insert-media-wpandroid-15 1-rc-2 image-block-retry-uploading-wpandroid-15 1-rc-2

Tested with WPAndroid 15.1-rc-2 from the Play Store on Pixel 4 Android 10 on WordPress.com Free site gotravelrewards.blog logged in as testuser0313.

@designsimply designsimply added [Type] Bug Something isn't working Media labels Jun 30, 2020
@hypest
Copy link
Contributor

hypest commented Jun 30, 2020

👋 Sheri!

Add items until you run out of space

Is there some message displayed when you reach that limit while in the Media Library?

@designsimply
Copy link
Contributor Author

designsimply commented Jul 1, 2020

Yes, when you reach the storage limit in WPAndroid a persistent notice is displayed at the bottom of the Media screen and a popup notice is displayed after trying to upload an item that goes beyond storage capacity. Note: there is an open request to improve the "EXCEEDS_SITE_SPACE_QUOTA_LIMIT" error message shown after an upload is attempted when the storage limit has been reached at wordpress-mobile/WordPress-Android#12325 (also see internal reference: paaHJt-17e-p2#comment-2413).

100% of 3 GB used

30 files not uploaded
EXCEEDS_SITE_SPACE_QUOTA_LIMIT

100-percent-of-3-gb-used exceeds_site_space_quota_limit

When you reach the storage limit in WPiOS, a generic error is shown after uploading an image past storage capacity (left) and a better error is shown after tapping on the failed image upload (right). Note: a request has been filed to ask for a more relevant error message to be shown sooner at wordpress-mobile/WordPress-iOS#14397.

1 post, 1 file not uploaded

Not enough space to upload
100% of 3 GB used on your site

1-post-1-file-not-uploaded-media-library-wpios-15 1 0 3 1-post-1-file-not-uploaded-media-library-after-tapping-retry-wpios-15 1 0 3 png

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 17, 2022

👋 @iamthomasbishop, I'm currently working on improving the overlay that displays in the image block when this error occurs and wanted to check-in for feedback on the design. At the moment, I've only added the reason for the failure between the "heading" about the failed upload and the prompt to tap the block for more options:

Before After

Note, the reason for the failure may not always be available, in which case the version of the error in the "before" screenshot will be used.

Is there anything you think should be changed in regards to the appearance here? Looking forward to hearing any thoughts or iterations!

@iamthomasbishop
Copy link
Contributor

@SiobhyB Thanks for the ping! I think it'd probably make sense to handle this the same way as the Media Library, which places the error message in the subsequent ActionSheet (presumably in the form of a BottomSheet on Android). If we do that, we can probably also refine the UI copy a little bit to something like "Tap for more info." Here's what that would look like all together:

Can we also center the text label on the block message ("Failed to insert media...")? Hadn't noticed that before because the first and second rows of text are almost exactly the same length 😄

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 17, 2022

@iamthomasbishop, there have been improvements that add the error to the action sheet since this issue was created. The current set up seems it's already in alignment with the route you're suggesting:

iOS Android

Separate from this, there's also the following open issue about iterating on the overlay message here, which is what I've been looking into: wordpress-mobile/WordPress-Android#13815

It sounds like the current set up (with the error only displaying in the action sheet) is preferable to the proposal to add the error to the overlay message. Is that right? If so, I can close that Android issue (as well as this one) and address the other tweaks you suggested separately.

@iamthomasbishop
Copy link
Contributor

there have been improvements that add the error to the action sheet since this issue was created

@SiobhyB Ahh, that's right, my bad!

It sounds like the current set up (with the error only displaying in the action sheet) is preferable to the proposal to add the error to the overlay message. Is that right?

I think so. IMO, it makes more sense to defer the more verbose messaging to the ActionSheet/Dialog, provided the label on the overlay is phrased clearly enough.

I can close that Android issue (as well as this one) and address the other tweaks you suggested separately.

Sounds good and thank you! 🙇

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 21, 2022

Perfect, I'll go ahead to close this issue, as there are now appropriate warnings when a site's storage limit has been hit and will address the tweaks you've suggested to the error message in WordPress/gutenberg#38951.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Project: Flow improvements Revise/enhance various editing flows [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants