Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GIF badge to GIFs in editor #968

Open
2 of 4 tasks
iamthomasbishop opened this issue May 9, 2019 · 6 comments · Fixed by WordPress/gutenberg#38996
Open
2 of 4 tasks

Add GIF badge to GIFs in editor #968

iamthomasbishop opened this issue May 9, 2019 · 6 comments · Fixed by WordPress/gutenberg#38996
Assignees
Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile HACK week HACK week June 2020 Media [Pri] Low Proposal [Type] Enhancement Improves a current area of the editor

Comments

@iamthomasbishop
Copy link
Contributor

iamthomasbishop commented May 9, 2019

In Aztec, we showed a [GIF] badge over the top of .gif's – let's add that, and in the process set ourselves up for future badge re-use :)

Coverage:

  • Image block
  • Gallery block
  • Media&Text block
  • ?

Here's what it looks like on a variety of backdrops:

image

Specs:

image

image

  • Positioning: 10px from top left corner
  • Background color: #1A1A1A 50% alpha
  • Border-radius: 6px
  • Internal Padding: 3px 6px
  • Font-family: Sans-serif
  • Font-size: 14px
  • Font-weight: Semi-bold
  • Text-transform: Uppercase
  • Background Blur (iOS): 5pt
@iamthomasbishop iamthomasbishop added Proposal Media Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile labels May 9, 2019
@iamthomasbishop iamthomasbishop changed the title Add GIF label to GIFs in editor Add GIF badge to GIFs in editor May 9, 2019
@kmdupr33
Copy link

Linking updated styles that @iamthomasbishop linked to in #gutenberg-mobile.

@SergioEstevao
Copy link
Contributor

@iamthomasbishop I just implemented animated GIFs for the GB editor on the WPiOS app: wordpress-mobile/WordPress-iOS#14238

On Android the GIF already plays while on the GB editor.

Do you think we still need the GIF badge if the editor plays the animation?

@hypest hypest added the HACK week HACK week June 2020 label Jun 7, 2020
@iamthomasbishop
Copy link
Contributor Author

Do you think we still need the GIF badge if the editor plays the animation?

@SergioEstevao Yea, I think the badge should always be displayed, even while it's animated.

@hypest
Copy link
Contributor

hypest commented Mar 30, 2022

Looks like the badge is not displaying in various cases of the Gallery Block or a Media&Text block so, reopening this ticket to track.

@hypest hypest reopened this Mar 30, 2022
@thehenrybyrd
Copy link

Related, we have this older issue for Image Gallery: #1715

@hypest
Copy link
Contributor

hypest commented Mar 31, 2022

👋 @illusaen , since you recently worked on adding the GIF badge, can you have another look to see how to have all types of image blocks display it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile HACK week HACK week June 2020 Media [Pri] Low Proposal [Type] Enhancement Improves a current area of the editor
Projects
None yet
6 participants