-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore support for animated GIFs in Gutenberg. #14238
Restore support for animated GIFs in Gutenberg. #14238
Conversation
When we implemented our custom ImageLoader for RN, to support private sites, we accidentally remove support for playing animated GIFs while inside GB editor. This PR changes the loading system of images to use the RCTAnimated class when a GIF is being download. One of the side effects of that change is that if now the featured image on the post/page is an animated GIF we show the animation.
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests I ran worked fine, GIFs are animated on the post list, in Gutenberg (doesn't work on Aztec, but I guess that's expected). I'd appreciate if someone else was reviewing the code ;).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @SergioEstevao for this fix!
I was wondering from some time already what happened to the animated gifs on iOS 😬
Added a couple of comments on the code, but everything works great!
When we implemented our custom ImageLoader for RN, to support private sites, we accidentally removed support for playing animated GIFs while inside GB editor.
This PR changes the loading system of images to use the
RCTAnimated
class when a GIF is being downloaded.One of the side effects of that change is that if the post featured image on the post/page is an animated GIF we show the animation.
Fixes #
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.