[RNMobile] Pass the ol start and reversed to native RichText too #39354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypest
changed the title
hypest
added
the
Mobile App - Automation
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
|
Interesting, there's a native mobile E2E test failing. Will look into this. EDIT: Flakyness. |
|
OK, looks like the not-relevant Admin failing tests are now fixed so, feel free to review this when you find the chance @geriux , thanks! |
Of course, will do 👍 |
geriux
approved these changes
Mar 15, 2022
This was referenced Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #30623
Why?
The changes in this PR are needed to fix the issue.
How?
This PR passes the
startandreversedordered list block props down to the native mobile RichText component.Also note, I renamed a few of the
start,endvariables to not shadow thestartcoming in as the prop. I kept the incoming prop asstartas that's the variable name used for the starting number of the list elsewhere in the codebase. Open to revising the approach.Testing Instructions
1.,2.,3.in orderReverse list numberingtoggle3.,2.,1.in order (reversed than before)Start valuefield and put a number like88.,7.,6.in order (counting down from the inputted start value)