Stories fixes for 16.3 beta #13539
Merged
Stories fixes for 16.3 beta #13539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng saved, to avoid sending a Post containing a story block with temporary ids
…unsupported WP Stories: Only show Story block in GB picker if supported by the site
Fixes a StringIndexOutOfBoundsException when the Story block is not the first block in the post. Previously the end of the first block would be matched, causing the substring end index to be earlier than the start index.
…exoutofbounds Stories: Fix StringIndexOutOfBoundsException when below another block
…sets Update Story intro screen assets and links
…saving-finish WP Stories: only allow updating a Post to the server when a Story is finished being saved
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
…ranslation" This reverts commit b08311d.
WP Stories: bring upload icon back, to trigger media picker from the camera preview mode
…e feeding the Story composer
WP Stories: changed flow for remote media from WP site to be copied locally
mzorz
approved these changes
Dec 5, 2020
There was a problem hiding this comment.
Alright!
I smoke tested several paths:
- adding photos and videos from device
- adding photos and videos from WP media library
- adding from free photo library
- inserting, deleting, editing on gutenberg
- adding new Story blocks in gutenberg
- light and dark themes in gutenberg, checked the Story block icon in the picker appears correctly
LGTM
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few already reviewed and merged PRs, which were bugfixes for 16.3-rc-1 for the Stories feature.
Specific PRs included:
#13517
#13518
#13525
#13526
#13543
#13548
Automattic/stories-android#613
Automattic/stories-android#621
Automattic/stories-android#623
Automattic/stories-android#625
To test:
Do a quick smoke test that Stories builds and runs, all work has already been reviewed.
PR submission checklist:
RELEASE-NOTES.txtif necessary.