Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Stories: bring upload icon back, to trigger media picker from the camera preview mode #13543

Merged
merged 5 commits into from
Dec 4, 2020

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Dec 4, 2020

Fixes Automattic/stories-android#617

Related stories library PR: Automattic/stories-android#623

To test:
See instructions in the related PR
upload_icon

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mzorz mzorz added this to the 16.3 ❄️ milestone Dec 4, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 4, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 4, 2020

You can test the changes on this Pull Request by downloading the APK here.

@mzorz
Copy link
Contributor Author

mzorz commented Dec 4, 2020

Merging since the burden of the change is in the Stories lib, and the related Stories lib PR is approved & merged Automattic/stories-android#623

@mzorz mzorz merged commit d5f9e63 into fix/stories-for-16.3 Dec 4, 2020
@mzorz mzorz deleted the fix/bring-thumbnail-back branch December 4, 2020 19:21
@mzorz mzorz mentioned this pull request Dec 4, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant