Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated stories library hash to latest #13686

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Dec 29, 2020

Somehow the stories library hash was downgraded back to the latest on November 27th instead of pointing to stories-library's develop.

Somehow some merge afterwards missed the right conflict resolution but, given there were no compilation issues it all just worked out.

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mzorz mzorz added this to the 16.4 ❄️ milestone Dec 29, 2020
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@mzorz mzorz changed the title Updated stories library hash to latest, somehow it got lost Updated stories library hash to latest Dec 29, 2020
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@mzorz mzorz marked this pull request as ready for review December 29, 2020 15:12
@mzorz mzorz requested a review from loremattei December 29, 2020 15:37
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@loremattei loremattei merged commit 623ed82 into release/16.4 Dec 29, 2020
@loremattei loremattei deleted the fix/update-stories-lib branch December 29, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants