Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Story intro screen assets and links #13526

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Update Story intro screen assets and links #13526

merged 1 commit into from
Dec 3, 2020

Conversation

aforcier
Copy link
Contributor

@aforcier aforcier commented Dec 3, 2020

Updates the Intro to Stories screen:

  • New, generic URLs for the intro/example story links (the posts themselves are a WIP right now, but the URLs won't change)
  • Updated the preview images to reflect the new posts

stories-new-intro

cc @megsfulton

To test:

  • Clear data so you'll be shown the Introducing Story Posts screen, in case you've already dismissed it
  • Check that the two story images show up correctly
  • Check that the links are valid

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@aforcier aforcier added this to the 16.3 ❄️ milestone Dec 3, 2020
@aforcier aforcier requested a review from mzorz December 3, 2020 04:39
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@megsfulton
Copy link

:shipit:

mzorz
mzorz approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving and merging since we got the :shipit: from @megsfulton 🎉

@mzorz mzorz merged commit 88e2f3a into fix/stories-for-16.3 Dec 3, 2020
@mzorz mzorz deleted the update/story-intro-assets branch December 3, 2020 17:50
@aforcier aforcier mentioned this pull request Dec 4, 2020
Merged
3 tasks
@bjtitus bjtitus mentioned this pull request Feb 8, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.3
Development

Successfully merging this pull request may close these issues.
3 participants
@aforcier @megsfulton @mzorz