-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New stories intro assets and links #15825
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bjtitus, I took this for spin and it seems to work and the images now load for the two demo stories.
There's a few things I've noticed, but since I'm not familiar with the project or whether there are some know issues I'll list here everything I came across (some might not correspond to this PR, not sure).
Red screen
Although the first time I tapped "Story post" on the FAB it worked, the second time I got a blank red screen (not the React Native red error screen, just a plain red screen):
Pixelated images
- The small blue WordPress icon on the top-left corner of the demo stories screens is pixelated on an iPhone 11
- This demo screen doesn't look high enough resolution for the iPhone 11 I was using, especially noticeable on this screen that shows image selection:
Android back buttons in demo content
This one is a bit subjective but the demo story shows and Android screen (back buttons, etc) which stand out IMO when using the app on an iPhone
Loading flicker
As the demo stories load, there's some flicker as a dark gray loading screen is shown (maybe using a lighter-colored loading screen would reduce flicker). I understand if this is content loaded from the web, but thought I'd mention it:
Here's a few frames during loading that show what looks to be causing the flicker:
White screen | Small black flicker | Grey loading screen |
---|---|---|
Loading indicator
I'm not sure if this is a bug, but the loading indicator step for the final image in the story doesn't load (not sure if that's expected):
Barring the red screen, the rest don't really look like blockers for this PR (let me know though if the red screen is not a blocker for this PR either and I can approve this).
Thanks @guarani!
This is expected. The Stories editor screen hasn't been merged in yet and the red is a placeholder.
I believe the favicon issue is a bug on web. It looks like we should be requesting a larger image size at 2x like we do in some other places. I'm checking to see if the stories content image is pixelated because of the 2x scaling again, or if it's just the compression from the export on Android.
This is expected for now. We should probably consider adding iOS specific demos.
This seems like a bug. I'll follow up with @aforcier to see if we are tracking it on web. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guarani!
the second time I got a blank red screen
This is expected. The Stories editor screen hasn't been merged in yet and the red is a placeholder.
Ok, great! I wasn't sure what stage this was at so wasn't sure if it was expected or not – thanks for the context!
Pixelated images
I believe the favicon issue is a bug on web. It looks like we should be requesting a larger image size at 2x like we do in some other places.
I'm checking to see if the stories content image is pixelated because of the 2x scaling again, or if it's just the compression from the export on Android.
👍
Android back buttons in demo content
This is expected for now. We should probably consider adding iOS specific demos.
No worries.
Loading indicator
This seems like a bug. I'll follow up with @aforcier to see if we are tracking it on web.
Thanks! The loading flicker I mentioned above might also be a bug.
👋 We're freezing |
Thanks for the detailed issue reports @guarani! I have some notes on some of the web-related stuff:
That one's a known issue that was resolved in the past but seems to have reappeared (at least for WordPress.com sites). It's logged and I'll look into it.
Looking at the original uploaded video that's being played in that slide, it looks like that's just the upload quality of the video and not a playback issue.
This one's a known issue - we've mostly been seeing it on Mobile Chrome, but I added a note that it's happening on Safari as well.
I wasn't able to reproduce this, the indicator is working correctly for me throughout both stories for this PR (note that it's a progress bar not a loading indicator, and in the case of videos will match the length of the video - the screenshot shared is at the very start of the video, where no progress would be showing yet, I'm not sure if that accounts for what you're seeing or if there's more going on @guarani ). |
Cool, thanks @aforcier!
Ok
🙇
True, it is a progress bar :) I tried it again today and couldn't reproduce on that slide. But there were other slides on both demo stories that sometimes didn't play at first (perhaps it was an internet issue) and after going back and forth between the slides, in some cases they eventually played. |
Adds new assets and links for the Stories intro screen.
The iOS counterpart of wordpress-mobile/WordPress-Android#13526
Testing
storiesIntroWasAcknowledged
User Default).PR submission checklist:
RELEASE-NOTES.txt
if necessary.