WP Stories: changed flow for remote media from WP site to be copied locally #13548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, instead of passing a remote URL to StoryComposerActivity through
onActivityResult()
, we're first making a local copy of it and then passing it over to the composer.It has proven to have better results and avoid metadata extractor not to be ready when needed in order to calculate the video size and rotation and so on.
I only made this test in the old PhotoPicker. We should follow up on this on the new media picker when it's also used in Stories. EDIT - tracked in #13549
To test:
Before this change, it would randomly err or crash when trying to save the video.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.