Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Picker: replicate behavior of making a local copy for remote media for Stories #13549

Closed
mzorz opened this issue Dec 4, 2020 · 2 comments

Comments

@mzorz
Copy link
Contributor

mzorz commented Dec 4, 2020

After the implementation of this PR #13548, we changed the behavior for the media picker for Stories when the user selects a media item which belongs to the site's Media section. Given these items are represented with remote URLs (i.e. https://) we need to first download a local copy in order for things to behave properly and smoothly in the Story composer while the user makes edits to their slides.

This behavior should be replicated in the new consolidated Media Picker once we move Stories to use the new media picker as well.

cc @aforcier

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority during regularly scheduled triage sessions.

@stale stale bot added the [Status] Stale label Jan 9, 2022
@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 6, 2024

Stories have been deprecated as of 24.1 (released to users yesterday), so I'll go ahead to close this issue.

@SiobhyB SiobhyB closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants