Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Stories: Only show Story block in GB picker if supported by the site #13517

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

aforcier
Copy link
Contributor

@aforcier aforcier commented Dec 2, 2020

I noticed that the Story block shows up in the Gutenberg picker for all sites - including non-Jetpack self-hosted sites and sites using older Jetpack versions.

To fix it I added the same check we use in the bottom sheets to determine whether the story feature is available.

Note: This PR should be included in the 16.3 release, so will require a new beta. I'm targeting fix/stories-for-16.3 for now though because there are one or two other issues that need to be resolved that may as well all be bundled into one updated beta cut.

To test:

  • For a WordPress.com or Jetpack 9.1+ site, check that the Story block shows up in the block picker
  • For a self-hosted non-Jetpack site, or a site running an older version of Jetpack, check that the Story block does not show up in the block picker

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@aforcier aforcier added this to the 16.3 ❄️ milestone Dec 2, 2020
@aforcier aforcier requested a review from mzorz December 2, 2020 01:39
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@aforcier aforcier changed the title Only show story block in picker if supported by site WP Stories: Only show Story block in GB picker if supported by the site Dec 2, 2020
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks for this change @aforcier !
LGTM :shipit:

@mzorz mzorz merged commit 4101525 into fix/stories-for-16.3 Dec 2, 2020
@mzorz mzorz deleted the fix/hide-story-block-unsupported branch December 2, 2020 02:54
@aforcier aforcier mentioned this pull request Dec 4, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants