chore: release 1.0.0-rc.10 #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
this already works fine on desktop, but was not implemented in mobile
update from requires 2 characters but register from requires at least 1 (vee-validate require rule) M2-706
- province/state will be now properly displayed on the shipping and billing steps
M2-677 M2-725
before this change, you couldn't enter the password input box on mobile
this visual issue happens because of the default behavior of the HTML `<select>` If the select's value doesn't match any option, it will display the first option by default The problem is that SfSelect (wrapper on top of select) is keeps that behavior, but moves the form label to the top ONLY if its `value` prop is truthy So it's a collision of two implementations: * SfSelect moving label to the top only when value is truthy (or if a placeholder exists, but that doesn't fit here) * HTML `select` displays first option if no option with given value is found The result is the first option being visible with SfSelect label not moved to the top. M2-751
…isiting my account wishlist (#1130)
this commit was made because app store buttons were overlapping on the homepage and looked unprofessional the issue was caused by a style spill ".sf-banner img" - the sf-banner does have a large image, but in this case the style is unintentionally applied to *any* image in the sf-banner body. even in the call to action
…d-to-cart fix: m2-743. incorrect add-to-cart label on mobile menu
…-is-wrongly-recalculated-after-using-currency-checker-while-checking-product-details fix!: m2-668 fixed price recalculation for configurable products
github-actions
bot
requested review from
Frodigo,
bartoszherba and
sethidden
as code owners
- if a country has region list the name of region will be displayed instead of a code
build: changed recaptcha config
…e-state-value-displayed-as-a-code-after-adding-new-address fix: m2-596. my account province state value displayed as a code
…-login-and-registration-dont-work fix: m2-917. login registration does not work with recaptcha
|
Deployed to the stage, ready for QA. |
…e-button-add-to-cart-doesnt-work-for-configurable-products fix: button add to cart doesn't work for configurable products
…eaks-the-application fix: currency cookie breaks the application
Frodigo
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue Storefront for Magento 1.0.0-rc.10 highlights
New features
Bugfix
Refactors
Performance
Tests
Chore
Repository
Documentation