fix: user addresses - reset region if changing country #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frodigo
approved these changes
Jun 17, 2022
Frodigo
pushed a commit
that referenced
this pull request
Jun 22, 2022
Frodigo
pushed a commit
that referenced
this pull request
Jun 22, 2022
Frodigo
pushed a commit
that referenced
this pull request
Jul 4, 2022
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR if you changed from a country with available_regions to one that didn't have regions, updating the address would silently fail. That happened because the app would send the stale region_id information and attempt to set eg. Germany's region_id for the country Czech Republic, which would never be found.