refactor: user addresses styling #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszherba
approved these changes
Jun 28, 2022
sethidden
approved these changes
Jun 28, 2022
Frodigo
deleted the
M2-709-shipping-billing-page-design-looks-broken-when-user-has-many-addresses
branch
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR user addresses styles on checkout were fixed only on the shipping step.
I realized that the SCSS code was duplicated for the shipping and billing step so I moved the SCSS code to a separate file.
I changed class names (they are scoped so we don't need to use prefixes like .shipping__addresses or .billing__adresses.) to use simpler classes like .addresses and .address.
Now styles for addresses in shipping and billing steps are correct and the code is not duplicated anymore.
Billing step
Shipping step
Mobile
M2-709