fix: country SfSelect overlapping with value #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this visual issue happens because of the default behavior of the HTML `<select>` If the select's value doesn't match any option, it will display the first option by default The problem is that SfSelect (wrapper on top of select) is keeps that behavior, but moves the form label to the top ONLY if its `value` prop is truthy So it's a collision of two implementations: * SfSelect moving label to the top only when value is truthy (or if a placeholder exists, but that doesn't fit here) * HTML `select` displays first option if no option with given value is found The result is the first option being visible with SfSelect label not moved to the top. M2-751
Frodigo
approved these changes
Jun 17, 2022
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this visual issue happens because of the default behavior of the HTML
<select>If the select's value doesn't match any option, it will display the
first option by default
The problem is that SfSelect (wrapper on top of select) is keeps that
behavior, but moves the form label to the top ONLY if its
valuepropis truthy
So it's a collision of two implementations:
placeholder exists, but that doesn't fit here)
selectdisplays first option if no option with given value is foundThe result is the first option being visible with SfSelect label not
moved to the top.
M2-751