ci: create gh deployment entry as early as possible #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
force-pushed
the
M2-848
branch
4 times, most recently
from
f47a278 to
e6e50ab
Compare
sethidden
commented
Jun 21, 2022
| @@ -2,42 +2,23 @@ | |||
| on: | |||
| workflow_call: | |||
| inputs: | |||
| github_environment_name: | |||
There was a problem hiding this comment.
deployment logic was moved out from this file. now it handles only the curl to vsf cloud
sethidden
commented
Jun 21, 2022
| @@ -65,54 +112,33 @@ jobs: | |||
|
|
|||
| LAST_COMMIT: ${{ github.sha }} | |||
|
|
|||
| deploy-main: | |||
There was a problem hiding this comment.
No need for multiple deploys blocks now. They were only for assigning the correct environment name to a branch, but now this is handled by the bash script at the top of the file.
sethidden
commented
Jun 21, 2022
|
|
||
| - name: Create GitHub deployment | ||
| id: deployment | ||
| uses: chrnorm/deployment-action@v2 |
There was a problem hiding this comment.
updated deployment-action and deployment-status to v2 from v1 - these are moslty naming convention changes and some alignments with gh api, so this should be a bit more up to date/easier to follow along with
Frodigo
approved these changes
Jun 22, 2022
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts a deployment as soon as the
deploy to vsf cloudaction starts. Previously it only created a deployment after the build - before the curl to vsf cloud / farmer. It's worth mentioning the build->deploy process is a single workflow. We don't upload artifacts in separate steps or anything.The previous implementation was insufficient as today in the morning there's been some NPM failures which broke the
deploy to vsf cloudworkflow builds, but the deployments did not appear at all. This led to our QA seeing the tasks in JIRA have the QA status, but not being able to tell if they're already deployed or not.Now if a situation like this happens again, a deployment will exist and it will show up as failed.
As you can see by the number of deployments below, I've checked if this PR actually works by using the defunct enterprise environment for testing.