Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty list of currencies while trying to change currency #1183

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Jun 30, 2022

Description

  • currency and store switcher will no behave in the same way on the desktop and the mobile

Related Issue

Motivation and Context

bugfix

How Has This Been Tested?

  1. go to https://demo-magento2-canary.europe-west1.gcp.storefrontcloud.io/default
  2. create account
  3. add shipping address in user settings and set it as default
  4. add product to cart and proceed to chekout
  5. try to select shipping method

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- currency and store switcher will no behave in the same way on the desktop and the mobile
@bartoszherba bartoszherba merged commit e3f41b0 into develop Jul 1, 2022
@bartoszherba bartoszherba deleted the M2-693-empty-list-of-currencies-while-trying-to-change-currency branch July 1, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants