Npe message fix for maintenance #4441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trigger productionMode and IgnoreIE11 in BrowserStack * Revert productionMode activation * activate production mode only on browserstack property * Use TestBench queries in ChildOrderIT * Improve browser checking in BodyScrollIT * Try to fix CompositeIT with waitForElementPresent * Wait for shadow-root child in ChildOrderIT * Increase timeout for ChildOrderIT * Revert "Increase timeout for ChildOrderIT" This reverts commit 435dc81. * Revert "Wait for shadow-root child in ChildOrderIT" This reverts commit 1d40a78. * Revert "Use TestBench queries in ChildOrderIT" This reverts commit 6deceaa. * Merge branch 'master' into ie11-conf * Remove es5 folder config * Move ExportedJSFunction tests out of test-root-context * Move ClientSideExceptionHandling tests out of test-root-context * Move InfoIT out of test-root-context * Move frontend protocol tests out of test-root-context * Add description for flow-test-dev-mode * Merge branch 'master' into ie11-conf
* Fix PaperInputIT by moving to the end of the field before typing * Fix AttachExistingDomElementByIdIT by using tab instead of enter to commit the value change of an input field * WebComponentsIT: Skip browser log API which doesn't exist for IE11 * Move ExceptionStackTraceIT to test-dev-mode because stack trace is not shown in production mode * Use TB query instead of getInShadowRoot
* Send 404 for non-existing frontend resources
Do it ONLY if the target is the flow-component-renderer element itself. Fixes grid#122
* Add RPC support for composite components * Support composite of composite * Split method search in hierarchy
* Update frontend tools. * Variant information is written to the analyzer. * Support new json filed in generator. * Add javadocs.
* Add HasTheme interface if variants are present for the component.
* Generate theme variants as enums.
* HasTheme supports theme variants now.
* Add missing components to analysis to get their variants.
* Add Lumo theme variants.
* Generate theme variants with classes.
* Regenerate the components
* Code review fixes.
* Regenerate the components
* Wrap tag name in {@code}.
* Regenerate the components
* Add generated annotation to the class.
* Regenerate the components
* Update Copyright Header * Update Since tag
Add an automatic PWA initialisation annotation for Flow-based projects.
…4396) * Update all components to versions with Material Theme support.
* Make inactive nodes mark their children as dirty on setInactive This moves the setting of dirty nodes out of the collectChanges method. When using long-polling push, the client keeps asking for changes from the server. The server then collects all the changes and sends to the client. The problem is: a child node is always considered `dirty`, if its parent is invisible, and the node is always included in the changes sent to the client. Since there's not a single moment where there's nothing to send, the server keeps sending the changes, and the client keeps asking for the changes. This creates a busy loop between client and server, which only ends when the parent node is made visible again. To prevent this, this patch changes this logic to make the children nodes only dirty when the parent visibility changes. Fix #4353
If we plan to show Material theme examples, we need this dependency for it.
* Move hierarachical data to flow-data Part of vaadin/vaadin-grid-flow#265
* Enable the test to check the added variant * Adding one more method to the test class
* Stream resource test (targeted for OSGi).
* Make ArrayUpdater backwards compatible * Create the HierarchicalArrayUpdater interface With the HierarchicalArrayUpdater interface, the logic needed for TreeGrid (or any hierarchical listing component) is separated from the ArrayUpater interface, making the ArrayUpater itself backwards compatible.
* Try not to lose the weak reference of UI during the test
* Add API diff via profile in the vaadin-parent project Fix for #4419
…er inside Felix OSGi (#4416)
vaadin-bot
reviewed
Jul 26, 2018
| updatedButtonText.startsWith("Remove")); | ||
| Assert.assertEquals( | ||
| "When a theme variant got added, component 'theme' attribute should contain one more variant that before", | ||
| previousThemes.size() + 1, updatedThemes.size()); |
There was a problem hiding this comment.
vaadin-bot
reviewed
Jul 26, 2018
| /** | ||
| * Base class for the integration tests of component demos. | ||
| * | ||
| */ | ||
| public abstract class ComponentDemoTest extends ChromeBrowserTest { | ||
| protected WebElement layout; | ||
|
|
||
| /** |
There was a problem hiding this comment.
vaadin-bot
reviewed
Jul 26, 2018
| } | ||
| } | ||
|
|
||
| private Function<WebElement, String> DEFAULT_VARIANT_PRODUCER = new DefaultProducer(); |
There was a problem hiding this comment.
vaadin-bot
reviewed
Jul 26, 2018
| updatedButtonText.startsWith("Add")); | ||
| Assert.assertEquals( | ||
| "When a theme variant got removed, component 'theme' attribute should contain one less variant than before", | ||
| previousThemes.size() - 1, updatedThemes.size()); |
There was a problem hiding this comment.
vaadin-bot
reviewed
Jul 26, 2018
| @@ -21,7 +21,6 @@ | |||
| /** | |||
There was a problem hiding this comment.
vaadin-bot
reviewed
Jul 26, 2018
| @@ -20,7 +20,6 @@ | |||
| /** | |||
There was a problem hiding this comment.
|
SonarQube analysis reported 21 issues
Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is