Add theme variants demo and test helpers. #4412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeoneToIgnore
force-pushed
the
kb/add-theme-variants-helpers
branch
from
dcf6f1a to
d96d04d
Compare
vaadin-bot
reviewed
Jul 17, 2018
| updatedButtonText.startsWith("Remove")); | ||
| Assert.assertEquals( | ||
| "When a theme variant got added, component 'theme' attribute should contain one more variant that before", | ||
| previousThemes.size() + 1, updatedThemes.size()); |
There was a problem hiding this comment.
vaadin-bot
reviewed
Jul 17, 2018
| updatedButtonText.startsWith("Add")); | ||
| Assert.assertEquals( | ||
| "When a theme variant got removed, component 'theme' attribute should contain one less variant than before", | ||
| previousThemes.size() - 1, updatedThemes.size()); |
There was a problem hiding this comment.
SomeoneToIgnore
force-pushed
the
kb/add-theme-variants-helpers
branch
from
d96d04d to
265d5f1
Compare
SomeoneToIgnore
force-pushed
the
kb/add-theme-variants-helpers
branch
from
265d5f1 to
22a698d
Compare
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. |
gilberto-torrezan
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4318
According to the task mentioned above, I need to add demos (and hence tests) to components:
It's easier to do that in generic way, by adding methods that set things up for us.
Usage example: vaadin/vaadin-text-field-flow#91