Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OSGI-compatible gentyref. #4327

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Use OSGI-compatible gentyref. #4327

merged 1 commit into from
Jun 25, 2018

Conversation

SomeoneToIgnore
Copy link
Contributor

Closes #4226

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR Binder.java#L764: Remove usage of generic wildcard type. rule
  2. MAJOR AbstractSinglePropertyField.java#L251: Remove this call from a constructor to the overridable "getElement" method. rule
  3. MINOR Binder.java#L708: "public" is redundant in this context. rule

@SomeoneToIgnore SomeoneToIgnore merged commit 707c166 into master Jun 25, 2018
@SomeoneToIgnore SomeoneToIgnore deleted the kb/4226_osgi-and-gentyref branch June 25, 2018 13:23
@SomeoneToIgnore
Copy link
Contributor Author

Had to fall back to Vaadin fork in #4332 since package imports change is a breaking one which is not allowed currently.

@gilberto-torrezan gilberto-torrezan added this to the 1.1.0.alpha1 milestone Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-anisimov denis-anisimov denis-anisimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0.alpha1
Development

Successfully merging this pull request may close these issues.
4 participants
@SomeoneToIgnore @vaadin-bot @denis-anisimov @gilberto-torrezan