Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try not to lose the weak reference of UI during the test #4431

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Try not to lose the weak reference of UI during the test #4431

merged 1 commit into from
Jul 23, 2018

Conversation

gilberto-torrezan
Copy link
Contributor

@gilberto-torrezan gilberto-torrezan commented Jul 23, 2018 •
edited by SomeoneToIgnore
Loading

This change is Reviewable

@gilberto-torrezan gilberto-torrezan added this to the 1.1 milestone Jul 23, 2018
@gilberto-torrezan gilberto-torrezan self-assigned this Jul 23, 2018
ZheSun88
ZheSun88 approved these changes Jul 23, 2018
View reviewed changes
Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale

@ZheSun88 ZheSun88 merged commit 611e70a into master Jul 23, 2018
@ZheSun88 ZheSun88 deleted the gilberto/serialization_test branch July 23, 2018 13:36
@pekam pekam modified the milestones: 1.1, 1.1.0.alpha2 Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZheSun88 ZheSun88 ZheSun88 approved these changes

Assignees

@gilberto-torrezan gilberto-torrezan

Labels
None yet
Projects
None yet
Milestone
1.1.0.alpha2
Development

Successfully merging this pull request may close these issues.
3 participants
@gilberto-torrezan @ZheSun88 @pekam