Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate a click from flow-component-renderer to the first child #4270

Merged
merged 2 commits into from
Jun 25, 2018

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Jun 12, 2018

Do it ONLY if the target is the flow-component-renderer element itself.

Fixes grid#122


This change is Reviewable

Denis Anisimov added 2 commits June 12, 2018 13:06
Do it ONLY if the target is the flow-component-renderer element itself.

Fixes grid#122
@denis-anisimov
Copy link
Contributor Author

Review status: 1 unresolved discussion, 0 of 1 LGTMs obtained


a discussion (no related file):
May not be merged before Flow release.


Comments from Reviewable

@SomeoneToIgnore
Copy link
Contributor

Reviewed 1 of 1 files at r1.
Review status: all discussions resolved, 0 of 1 LGTMs obtained


Comments from Reviewable

@denis-anisimov
Copy link
Contributor Author

:lgtm:


Review status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale


Comments from Reviewable

@denis-anisimov denis-anisimov merged commit cab1b5d into master Jun 25, 2018
@denis-anisimov denis-anisimov deleted the 122-click-listener-inside-renderer branch June 25, 2018 16:54
gilberto-torrezan pushed a commit that referenced this pull request Jul 11, 2018
Do it ONLY if the target is the flow-component-renderer element itself.

Fixes grid#122
gilberto-torrezan pushed a commit that referenced this pull request Jul 11, 2018
Do it ONLY if the target is the flow-component-renderer element itself.

Fixes grid#122
@gilberto-torrezan gilberto-torrezan added this to the 1.0.1 milestone Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants