Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

Enable IT test for clicking a button inside Grid via keyboard #227

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Enable IT test for clicking a button inside Grid via keyboard #227

merged 1 commit into from
Jun 26, 2018

Conversation

denis-anisimov
Copy link

@denis-anisimov denis-anisimov commented Jun 12, 2018 •
edited by ZheSun88
Loading

A part of fix for #122

This change is Reviewable

@denis-anisimov
Copy link
Author

Enabled test for vaadin/flow#4270

@denis-anisimov
Copy link
Author

Review status: 0 of 1 files reviewed, 1 unresolved discussion

a discussion (no related file):
This is waiting for vaadin/flow#4270 and may not be merged before release (along with the 4270).

Comments from Reviewable

@denis-anisimov denis-anisimov force-pushed the 122-click-button-by-keyboard branch from 1f2ebee to 364b182 Compare June 26, 2018 07:57
@caalador
Copy link
Contributor

Reviewed 1 of 1 files at r1.
Review status: all files reviewed, 1 unresolved discussion

Comments from Reviewable

@caalador caalador merged commit 67eea3a into master Jun 26, 2018
@caalador caalador deleted the 122-click-button-by-keyboard branch June 26, 2018 08:11
ZheSun88 pushed a commit that referenced this pull request Jul 16, 2018
@ZheSun88
Enable IT test for clicking a button inside Grid via keyboard (#227)
c5c5be2 
A part of fix for #122
denis-anisimov pushed a commit that referenced this pull request Jul 16, 2018
@ZheSun88
Maintenance release picks (#259)
e49702e 
* Enable IT test for clicking a button inside Grid via keyboard (#227)

* This way we update the serverside sorting always after the
sorter-changed event has been handled by grid.

* Renderer getters (#251)

* Add javadoc to renderer getters (#254)
ZheSun88 pushed a commit that referenced this pull request Jul 17, 2018
@ZheSun88
Enable IT test for clicking a button inside Grid via keyboard (#227)
085b794 
A part of fix for #122
ZheSun88 pushed a commit that referenced this pull request Jul 17, 2018
@ZheSun88
Enable IT test for clicking a button inside Grid via keyboard (#227)
590de12 
A part of fix for #122
ZheSun88 pushed a commit that referenced this pull request Jul 18, 2018
@ZheSun88
Enable IT test for clicking a button inside Grid via keyboard (#227)
710c099 
A part of fix for #122
@gilberto-torrezan gilberto-torrezan added this to the 1.1.0.alpha1 milestone Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0.alpha1
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-anisimov @caalador @gilberto-torrezan