Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

Add javadoc to Renderer getters #254

Merged
merged 5 commits into from
Jul 12, 2018
Merged

Add javadoc to Renderer getters #254

merged 5 commits into from
Jul 12, 2018

Conversation

OlliTietavainenVaadin
Copy link
Member

@OlliTietavainenVaadin OlliTietavainenVaadin commented Jul 11, 2018 •
edited
Loading

Added a javadoc comment saying getRenderer return value shouldn't be modified after Grid has been rendered

This change is Reviewable

@vaadin-bot
Copy link

SonarQube analysis reported 23 issues

  • CRITICAL 4 critical
  • MAJOR 6 major
  • MINOR 12 minor
  • INFO 1 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Grid.java#L115: Make "queue" transient or serializable. rule
  2. CRITICAL Grid.java#L161: Define a constant instead of duplicating this literal "This method can't be used for a Grid. Use TreeGrid instead." 3 times. rule
  3. CRITICAL Grid.java#L761: Make "detailsVisible" transient or serializable. rule
  4. CRITICAL Grid.java#L1629: Remove usage of generic wildcard type. rule
  5. MAJOR Grid.java#: This file has 1,189 lines, which is greater than 750 authorized. Split it into smaller files. rule
  6. MAJOR Grid.java#L1297: Call "Optional#isPresent()" before accessing the value. rule
  7. MAJOR Grid.java#L1298: Either log or rethrow this exception. rule
  8. MAJOR Grid.java#L1310: Either log or rethrow this exception. rule
  9. MAJOR Grid.java#L2044: Call "Optional#isPresent()" before accessing the value. rule
  10. MAJOR Grid.java#L2054: Call "Optional#isPresent()" before accessing the value. rule

ZheSun88
ZheSun88 approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@ZheSun88 ZheSun88 changed the title Renderer getters Add javadoc to Renderer getters Jul 12, 2018
@ZheSun88 ZheSun88 merged commit e80bd8d into vaadin:master Jul 12, 2018
ZheSun88 pushed a commit that referenced this pull request Jul 16, 2018
@OlliTietavainenVaadin @ZheSun88
Add javadoc to renderer getters (#254)
7f6c1f2 
Add javadoc to Renderer getters
denis-anisimov pushed a commit that referenced this pull request Jul 16, 2018
@ZheSun88
Maintenance release picks (#259)
e49702e 
* Enable IT test for clicking a button inside Grid via keyboard (#227)

* This way we update the serverside sorting always after the
sorter-changed event has been handled by grid.

* Renderer getters (#251)

* Add javadoc to renderer getters (#254)
@gilberto-torrezan gilberto-torrezan added this to the 1.1.0.alpha1 milestone Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZheSun88 ZheSun88 ZheSun88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0.alpha1
Development

Successfully merging this pull request may close these issues.
4 participants
@OlliTietavainenVaadin @vaadin-bot @ZheSun88 @gilberto-torrezan