Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

Maintenance release picks #259

Merged
merged 4 commits into from
Jul 16, 2018
Merged

Maintenance release picks #259

merged 4 commits into from
Jul 16, 2018

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Jul 16, 2018 •
edited
Loading

This change is Reviewable

Denis and others added 4 commits July 16, 2018 13:16
@ZheSun88
Enable IT test for clicking a button inside Grid via keyboard (#227)
c5c5be2 
A part of fix for #122
@caalador @ZheSun88
Observe changes in _previousSorters instead of using an eventListener. (
dfcda98 
#249)

* Observe changes in _previousSorters instead of using an eventListener.

This way we update the serverside sorting always after the
sorter-changed event has been handled by grid.
@OlliTietavainenVaadin @ZheSun88
Renderer getters (#251)
aae4446 
Added getter for Renderer passed in Column constructor, implements #197
@OlliTietavainenVaadin @ZheSun88
Add javadoc to renderer getters (#254)
7f6c1f2 
Add javadoc to Renderer getters
@ZheSun88 ZheSun88 self-assigned this Jul 16, 2018
@vaadin-bot
Copy link

SonarQube analysis reported 24 issues

  • CRITICAL 3 critical
  • MAJOR 6 major
  • MINOR 14 minor
  • INFO 1 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Grid.java#L112: Make "queue" transient or serializable. rule
  2. CRITICAL Grid.java#L717: Make "detailsVisible" transient or serializable. rule
  3. CRITICAL Grid.java#L1444: Remove usage of generic wildcard type. rule
  4. MAJOR Grid.java#: This file has 1,070 lines, which is greater than 750 authorized. Split it into smaller files. rule
  5. MAJOR Grid.java#L1112: Call "Optional#isPresent()" before accessing the value. rule
  6. MAJOR Grid.java#L1113: Either log or rethrow this exception. rule
  7. MAJOR Grid.java#L1125: Either log or rethrow this exception. rule
  8. MAJOR Grid.java#L1859: Call "Optional#isPresent()" before accessing the value. rule
  9. MAJOR Grid.java#L1869: Call "Optional#isPresent()" before accessing the value. rule
  10. MINOR Grid.java#L403: Remove this method to simply inherit it. rule

denis-anisimov
denis-anisimov approved these changes Jul 16, 2018
View reviewed changes
Copy link

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ZheSun88)

@denis-anisimov denis-anisimov merged commit e49702e into 1.0 Jul 16, 2018
@denis-anisimov denis-anisimov deleted the 1.0.1-release-cherry-pick branch July 16, 2018 10:46
ZheSun88 added a commit that referenced this pull request Jul 17, 2018
@ZheSun88
Revert "Maintenance release picks (#259)"
91e60a3 
This reverts commit e49702e.
@ZheSun88 ZheSun88 mentioned this pull request Jul 17, 2018
Merged
ZheSun88 added a commit that referenced this pull request Jul 17, 2018
@ZheSun88
Revert "Maintenance release picks (#259)"
55a22c3 
This reverts commit e49702e.
ZheSun88 added a commit that referenced this pull request Jul 17, 2018
@ZheSun88
Revert "Maintenance release picks" (#267)
d59f330 
* Revert "Maintenance release picks (#259)"

This reverts commit e49702e.
@gilberto-torrezan gilberto-torrezan added this to the Abandoned milestone Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denis-anisimov denis-anisimov denis-anisimov approved these changes

Assignees

@ZheSun88 ZheSun88

Labels
None yet
Projects
None yet
Milestone
Abandoned
Development

Successfully merging this pull request may close these issues.
6 participants
@ZheSun88 @vaadin-bot @denis-anisimov @gilberto-torrezan @caalador @OlliTietavainenVaadin