Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API diff via profile in the vaadin-parent project #4430

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Jul 23, 2018

Fix for #4419


This change is Reviewable

Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to change the release configuration

Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale

@ZheSun88 ZheSun88 merged commit 2759dee into master Jul 24, 2018
@ZheSun88 ZheSun88 deleted the 4419-use-api-diff branch July 24, 2018 05:50
@ZheSun88 ZheSun88 added this to the 1.1.0.alpha2 milestone Jul 24, 2018
ZheSun88 pushed a commit that referenced this pull request Jul 24, 2018
* Add API diff via profile in the vaadin-parent project

Fix for #4419
ZheSun88 added a commit that referenced this pull request Jul 24, 2018
* Add API diff via profile in the vaadin-parent project

Fix for #4419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants