Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API diff via profile in the vaadin-parent project (#4430) #4433

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Jul 24, 2018

  • Add API diff via profile in the vaadin-parent project

Fix for #4419


This change is Reviewable

* Add API diff via profile in the vaadin-parent project

Fix for #4419
@ZheSun88 ZheSun88 added this to the 1.0.3 milestone Jul 24, 2018
Copy link
Contributor

@pekam pekam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale

Copy link
Contributor

@denis-anisimov denis-anisimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained, and 1 stale

@ZheSun88 ZheSun88 merged commit 120d67c into 1.0 Jul 24, 2018
@ZheSun88 ZheSun88 deleted the 1.0-pick branch July 24, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants