LS: Move all LS startup logic to its library main function #5019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2024
commit-id:13cfed95
commit-id:78e7cc46
commit-id:9d6c145d
commit-id:94f4795c
This change removes the logic which passes CairoLS stdout to extension's logs. While this seems like a drawback, this logic was actually pretty unidiomatic and required early branching in LS binary searching code. CairoLS logs were printed by VSCode anyway in separate log channel. This code will be cleaned up further in subsequent commits. commit-id:74dcbc57
commit-id:67d23268
commit-id:fd8af7de
This commit also slightly changes the logic behind the
`${workspaceFolder}` placeholder. Now, it expands to empty string in
case there is no open workspace. This should not be a problem, because
it does not make sense to use this placeholder in global config.
commit-id:a58e04a6
commit-id:5ffc097f
commit-id:c0872618
commit-id:43ff3b1c
commit-id:30ace537
commit-id:f5c8f336
This change gives the LS crate exclusive control on its running environment and behaviours, like Tokio runtime or logging. commit-id:548527aa
mkaput
force-pushed
the
spr/main/f5c8f336
branch
from
7b4fe92
to
038f67a
Compare
mkaput
force-pushed
the
spr/main/548527aa
branch
from
6073c14
to
c1bb4e0
Compare
mkaput
force-pushed
the
spr/main/f5c8f336
branch
from
038f67a
to
8b23640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gives the LS crate exclusive control on its running
environment and behaviours, like Tokio runtime or logging.
Stack:
tracinginstead oflog#5021isScarbProjectlogic to separate file #5015StandaloneLSclass #5013Scarbclass #5012onEnterRules#5011Configclass #4976Scarbclass and move Scarb's LS discovery there #4974Contextand levelled logging #4959Contextclass #4934This change is